Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop packaging integrations for Python 2 #18580

Merged
merged 6 commits into from
Sep 13, 2024

Conversation

iliakur
Copy link
Contributor

@iliakur iliakur commented Sep 12, 2024

What does this PR do?

Motivation

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Changelog entries must be created for modifications to shipped code
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@steveny91
Copy link
Contributor

Looks good to me. But just to summarize the changes:

  • Delete py2 classifier tags
  • Changelog entries about dropping py2
  • Delete any py2 specific setup.py files
  • Cleaned up deps that were py2 specific

That correct?

steveny91
steveny91 previously approved these changes Sep 12, 2024
Copy link

codecov bot commented Sep 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.39%. Comparing base (decefb4) to head (2ae4bfa).
Report is 6 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
active_directory 72.72% <ø> (ø)
activemq 52.80% <ø> (ø)
activemq_xml 82.31% <ø> (ø)
aerospike 86.85% <ø> (ø)
amazon_msk 88.84% <ø> (ø)
ambari 85.80% <ø> (ø)
apache 95.08% <ø> (ø)
aspdotnet 100.00% <ø> (ø)
azure_iot_edge 82.08% <ø> (ø)
btrfs 82.91% <ø> (ø)
cacti 87.90% <ø> (ø)
calico 84.61% <ø> (ø)
cassandra 66.66% <ø> (ø)
cassandra_nodetool 93.16% <ø> (ø)
ceph 91.07% <ø> (ø)
cilium 77.35% <ø> (ø)
cisco_aci 94.93% <ø> (ø)
citrix_hypervisor 87.50% <ø> (ø)
clickhouse 94.18% <ø> (+0.02%) ⬆️
cloud_foundry_api 96.11% <ø> (ø)
cockroachdb 93.19% <ø> (ø)
confluent_platform 81.96% <ø> (?)
consul 91.82% <ø> (ø)
coredns 94.51% <ø> (ø)
couch 94.84% <ø> (+0.11%) ⬆️
couchbase 84.89% <ø> (ø)
crio 89.79% <ø> (ø)
datadog_checks_base 88.99% <ø> (+0.29%) ⬆️
datadog_checks_dev 77.31% <ø> (ø)
datadog_checks_downloader 81.35% <ø> (+3.23%) ⬆️
datadog_cluster_agent 90.19% <ø> (ø)
directory 95.03% <ø> (ø)
disk 90.76% <ø> (+1.42%) ⬆️
dns_check 93.33% <ø> (ø)
dotnetclr 72.22% <ø> (ø)
druid 97.70% <ø> (ø)
ecs_fargate 83.52% <ø> (ø)
eks_fargate 94.05% <ø> (ø)
elastic 93.34% <ø> (ø)
envoy 95.09% <ø> (+5.57%) ⬆️
esxi 93.05% <ø> (ø)
etcd 95.56% <ø> (ø)
exchange_server 74.24% <ø> (ø)
external_dns 89.28% <ø> (ø)
fluentd 84.32% <ø> (ø)
foundationdb 83.83% <ø> (ø)
gearmand 77.01% <ø> (ø)
gitlab 91.29% <ø> (ø)
gitlab_runner 92.10% <ø> (ø)
glusterfs 80.08% <ø> (ø)
go_expvar 92.73% <ø> (ø)
gunicorn 92.16% <ø> (-0.75%) ⬇️
haproxy 94.96% <ø> (ø)
harbor 89.65% <ø> (ø)
hazelcast 92.30% <ø> (ø)
hdfs_datanode 89.74% <ø> (ø)
hdfs_namenode 86.72% <ø> (ø)
hive ?
hivemq ?
http_check 93.76% <ø> (ø)
hudi 73.91% <ø> (ø)
ibm_ace 92.25% <ø> (ø)
ibm_db2 86.87% <ø> (ø)
ibm_i 81.91% <ø> (ø)
ibm_mq 91.26% <ø> (+0.13%) ⬆️
ibm_was 96.08% <ø> (ø)
ignite ?
iis 93.98% <ø> (ø)
istio 77.51% <ø> (ø)
jboss_wildfly ?
kafka 64.70% <ø> (ø)
kafka_consumer 93.03% <ø> (+1.54%) ⬆️
kong 87.56% <ø> (ø)
kube_apiserver_metrics 97.74% <ø> (ø)
kube_controller_manager 97.89% <ø> (ø)
kube_dns 95.97% <ø> (ø)
kube_metrics_server 94.87% <ø> (ø)
kube_proxy 96.80% <ø> (ø)
kube_scheduler 97.92% <ø> (ø)
kubelet 91.01% <ø> (ø)
kubernetes_state 89.50% <ø> (ø)
kyototycoon 85.96% <ø> (ø)
lighttpd 83.64% <ø> (ø)
linkerd 83.90% <ø> (ø)
linux_proc_extras 96.22% <ø> (ø)
mapr 82.42% <ø> (ø)
mapreduce 82.08% <ø> (ø)
marathon 83.12% <ø> (ø)
marklogic 96.10% <ø> (+2.36%) ⬆️
mcache 93.50% <ø> (ø)
mesos_master 89.81% <ø> (ø)
mesos_slave 93.31% <ø> (ø)
mysql 88.64% <ø> (+0.01%) ⬆️
nagios 89.01% <ø> (ø)
network 92.60% <ø> (ø)
nfsstat 95.20% <ø> (ø)
nginx 94.54% <ø> (ø)
nginx_ingress_controller 98.55% <ø> (ø)
openldap 96.33% <ø> (ø)
openmetrics 98.06% <ø> (ø)
openstack 55.19% <ø> (ø)
openstack_controller 94.44% <ø> (ø)
pdh_check 97.36% <ø> (ø)
pgbouncer 91.35% <ø> (ø)
php_fpm 89.71% <ø> (ø)
postfix 88.10% <ø> (ø)
powerdns_recursor 96.65% <ø> (ø)
presto ?
process 85.61% <ø> (ø)
prometheus 94.17% <ø> (ø)
proxysql 98.97% <ø> (ø)
rabbitmq 95.37% <ø> (ø)
redisdb 87.77% <ø> (ø)
rethinkdb 97.93% <ø> (ø)
riak 99.21% <ø> (ø)
riakcs 88.88% <ø> (ø)
sap_hana 90.44% <ø> (ø)
scylla 98.25% <ø> (ø)
silk 93.82% <ø> (ø)
singlestore 90.81% <ø> (ø)
snmp 95.71% <ø> (+<0.01%) ⬆️
snowflake 96.27% <ø> (ø)
solr ?
sonarqube 98.24% <ø> (ø)
spark 93.89% <ø> (ø)
squid 100.00% <ø> (ø)
ssh_check 91.77% <ø> (ø)
statsd 87.36% <ø> (ø)
supervisord 89.78% <ø> (ø)
system_core 92.66% <ø> (ø)
system_swap 98.30% <ø> (ø)
tcp_check 91.72% <ø> (+1.32%) ⬆️
teamcity 86.03% <ø> (ø)
teradata 94.05% <ø> (ø)
tls 91.41% <ø> (ø)
tomcat 60.41% <ø> (?)
twemproxy 79.56% <ø> (ø)
twistlock 80.47% <ø> (ø)
varnish 84.12% <ø> (ø)
vault 95.19% <ø> (+0.47%) ⬆️
vertica 98.34% <ø> (ø)
voltdb 96.85% <ø> (ø)
vsphere 96.15% <ø> (ø)
weblogic 71.73% <ø> (?)
win32_event_log 82.05% <ø> (ø)
windows_service 94.04% <ø> (ø)
wmi_check 97.50% <ø> (ø)
yarn 89.52% <ø> (ø)
zk 82.15% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Kyle-Neale
Kyle-Neale previously approved these changes Sep 12, 2024
julien-lebot
julien-lebot previously approved these changes Sep 13, 2024
@iliakur iliakur dismissed stale reviews from julien-lebot, Kyle-Neale, and steveny91 via 0562bc9 September 13, 2024 11:05
@iliakur iliakur merged commit 9a881d4 into master Sep 13, 2024
330 of 335 checks passed
@iliakur iliakur deleted the ik/AI-3958/Stop-packaging-integrations-for-Python-2 branch September 13, 2024 17:47
github-actions bot pushed a commit that referenced this pull request Sep 13, 2024
* Stop packaging integrations for Python 2 9a881d4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
base_package dependencies dependency_provider dev_package downloader integration/active_directory integration/activemq_xml integration/activemq integration/aerospike integration/amazon_msk integration/ambari integration/apache integration/aspdotnet integration/azure_iot_edge integration/btrfs integration/cacti integration/calico integration/cassandra_nodetool integration/cassandra integration/ceph integration/cilium integration/cisco_aci integration/citrix_hypervisor integration/clickhouse integration/cloud_foundry_api integration/cockroachdb integration/confluent_platform integration/consul integration/coredns integration/couch integration/couchbase integration/crio integration/datadog_checks_tests_helper integration/datadog_cluster_agent integration/directory integration/disk integration/dns_check integration/dotnetclr integration/druid integration/ecs_fargate integration/eks_fargate integration/elastic integration/envoy integration/esxi integration/etcd integration/exchange_server integration/external_dns integration/flink integration/fluentd integration/foundationdb integration/gearmand integration/gitlab_runner integration/gitlab integration/glusterfs integration/go_expvar integration/gunicorn integration/haproxy integration/harbor integration/hazelcast integration/hdfs_datanode integration/hdfs_namenode integration/http_check integration/hudi integration/hyperv integration/ibm_ace integration/ibm_db2 integration/ibm_i integration/ibm_mq integration/ibm_was integration/iis integration/istio integration/journald integration/kafka_consumer integration/kafka integration/kong integration/kube_apiserver_metrics integration/kube_controller_manager integration/kube_dns integration/kube_metrics_server integration/kube_proxy integration/kube_scheduler integration/kubelet integration/kubernetes_state integration/kyototycoon integration/lighttpd integration/linkerd integration/linux_proc_extras integration/mapr integration/mapreduce integration/marathon integration/marklogic integration/mcache integration/mesos_master integration/mesos_slave integration/mongo integration/mysql integration/nagios integration/network integration/nfsstat integration/nginx
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants